Mohammed Firdous

I contributed to PipeCD by fixing a bug where template variables weren't being rendered in certain analysis strategies, causing raw template strings to appear in logs and queries instead of actual values.

What is PipeCD?

PipeCD is a GitOps continuous deployment tool that automates application deployments to Kubernetes, ECS, Lambda, and other platforms. It provides progressive delivery features like canary deployments, blue-green deployments, and automated analysis stages that monitor metrics during deployments.

The Problem

PipeCD's analysis stage supports different strategies for monitoring deployments: CANARY_BASELINE, THRESHOLD, and PREVIOUS. The CANARY_BASELINE strategy correctly rendered template variables like {{ .App.Name }} into actual values, but THRESHOLD and PREVIOUS strategies were displaying raw template strings in logs and queries.

This inconsistency meant:

Users saw confusing template variables instead of actual application names in logs
Monitoring queries contained unprocessed template syntax
Different analysis strategies behaved inconsistently

My Solution

I updated the metrics_analyzer.go file to ensure all analysis strategies use the renderQuery method before executing queries:

Identified the inconsistency - Only CANARY_BASELINE was calling renderQuery
Applied the same pattern to THRESHOLD and PREVIOUS strategies
Unified the behavior across all analysis stage strategies
Ensured template variables get replaced with actual values in all cases

Review Process

The review process was collaborative and thorough:

Warashi (PipeCD maintainer) provided excellent guidance:

Initially helped identify the exact issue and solution approach
Requested proper commit signing for the project
Tested the changes with actual PipeCD deployments
Provided before/after screenshots showing the fix working
Approved the final implementation

ffjlabo performed the final review and merge, confirming the contribution met project standards.

Technical Impact

The fix ensures consistent behavior across all analysis strategies:

Users now see actual application names instead of template variables in logs
Monitoring queries execute with proper values
All analysis strategies follow the same template rendering pattern
Improved debugging experience for PipeCD users

Community Recognition

The contribution was quickly cherry-picked to the v0.52.2 release, demonstrating its importance for users. The maintainers also encouraged me to continue contributing to the project.